Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2255: Re-Re-names docker images #8

Merged

Conversation

flamingbear
Copy link
Member

@flamingbear flamingbear commented Dec 4, 2024

Description

This PR re-aligns the service names with how the other services are
named by using a Harmony approved service name.

Image name changes (important):

before: ghcr.io/nasa/harmony-smap-l2-gridding-service
after : ghcr.io/nasa/harmony-smap-l2-gridder

Unimportant:

I tried to be better with the naming conventions:

Discussing repository: harmony-SMAP-L2-gridding-service
Discussing the service: Harmony SMAP L2 gridding service
Images: harmony-smap-l2-gridder

previous PR: "I could have changed it to match the smap-l2-gridder but decided to follow the lead of other existing services."
Harmony folks suggested: harmony-smap-l2-gridder

Jira Issue ID

DAS-2255

Local Test Steps

Test steps are the same as before.

verify that you don't have any SMAP Docker images.

❯ docker images | grep smap
ghcr.io/nasa/harmony-smap-l2-gridder  ...

If you do, delete it:

❯ docker rmi ghcr.io/nasa/harmony-smap-l2-gridding-service

Pull this branch and build the image. Verify it has the correct name

❯ docker images | grep smap
ghcr.io/nasa/harmony-smap-l2-grider        latest...

PR Acceptance Checklist

  • [N/A] Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • [N/A] Tests added/updated and passing.
  • [N/A] Documentation updated (if needed).

@flamingbear flamingbear changed the title DAS-2255: Renames docker images DAS-2255: Re-Re-names docker images Dec 4, 2024
@flamingbear flamingbear merged commit 2381718 into nasa:main Dec 4, 2024
6 checks passed
@flamingbear flamingbear deleted the mhs/DAS-2255/rename-service-redux branch December 4, 2024 16:43
@flamingbear flamingbear restored the mhs/DAS-2255/rename-service-redux branch December 4, 2024 18:29
@flamingbear flamingbear deleted the mhs/DAS-2255/rename-service-redux branch December 4, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants