Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-aligns the service names with how the other services are
named by using a Harmony approved service name.
Image name changes (important):
before:
ghcr.io/nasa/harmony-smap-l2-gridding-service
after :
ghcr.io/nasa/harmony-smap-l2-gridder
Unimportant:
I tried to be better with the naming conventions:
Discussing repository:
harmony-SMAP-L2-gridding-service
Discussing the service:
Harmony SMAP L2 gridding service
Images:
harmony-smap-l2-gridder
previous PR: "I could have changed it to match the smap-l2-gridder but decided to follow the lead of other existing services."
Harmony folks suggested:
harmony-smap-l2-gridder
Jira Issue ID
DAS-2255
Local Test Steps
Test steps are the same as before.
verify that you don't have any SMAP Docker images.
If you do, delete it:
Pull this branch and build the image. Verify it has the correct name
PR Acceptance Checklist
CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.