Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename package from harmony to harmony_service_lib #45

Merged

Conversation

danielfromearth
Copy link
Contributor

@danielfromearth danielfromearth commented Sep 6, 2024

Jira Issue ID

HARMONY-1781

Description

Change the package name from harmony to harmony_service_lib.

Local Test Steps

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@danielfromearth danielfromearth marked this pull request as ready for review September 6, 2024 21:32
@owenlittlejohns
Copy link
Member

I think it might be worth locally trying to run make build to test out the new version of setuptools - when I just tried bumping that to 74.1.2, I get errors (which were resolved with this and bumping safety). But trying the fix ends up getting to deprecation warnings about using setup.py.

@chris-durbin
Copy link
Contributor

Thanks for implementing this PR! We're trying to figure out the issue Owen is mentioning (and reconciling with Owen's PR). When we merge this in we'll plan to update the major version since it will be a breaking change for everyone.

Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested with harmony-service-example.

Copy link
Member

@ygliuvt ygliuvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with harmony-service-example locally.

Copy link
Member

@owenlittlejohns owenlittlejohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes look functionally great. I used the library locally, and it works nicely. One thing I did spot was a bunch of doc-string comments that are now out of date. I can push a commit up with those now, though.

@chris-durbin chris-durbin merged commit baee473 into nasa:main Sep 30, 2024
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-44-rename-package branch October 15, 2024 15:45
@danielfromearth
Copy link
Contributor Author

Thanks @owenlittlejohns, @chris-durbin, @ygliuvt for your help in making this name change happen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants