Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmony 1978 - Add/create label from jobs page of workflow ui #681

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

vinnyinverso
Copy link
Collaborator

Jira Issue ID

HARMONY-1978

Description

Allows the user to add/create a label from jobs page of workflow ui.
Screenshot 2025-01-16 at 1 01 55 PM

Local Test Steps

  • select some jobs from http://localhost:3000/workflow-ui
  • click the "label" dropdown
  • type a label name in the dropdown (that does not already exist)
  • click the create/apply link
  • validate that the label was applied/created

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)
  • Harmony in a Box tested? (if changes made to microservices)

@vinnyinverso vinnyinverso marked this pull request as ready for review January 22, 2025 16:50
Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out locally. The basic functionality looks good and works as expected. There were a few things I found when testing:

  1. When creating a new label that label is not immediately available in the auto-complete for the filter box (on the left side of the page). Reloading the page makes that label available.
  2. I pasted in text that would have resulted in more than 255 characters, but my label was created successfully. I'm guessing it must have truncated? It's probably worth a message in the toast if it truncated the label to 255 characters.
  3. Filtering on a really long label leads to text that crosses the full width of the screen.
  4. Attempting to filter on a really long label isn't working (the results are not filtered).

3 and 4 are unrelated to this PR - probably should open a bug ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants