Inspector Tabs Updates #7987

jvigliotta · 2025-01-15T18:56:50Z

Closes #7442, #7959
Combination of two similar PR's

Describe your changes:

Whenever the selection changes, the first tab (highest priority) is auto selected. There may be some cases (editing styles) when we'd want that tab to stay selected as well. Also updates when and where the tabs show based on the items being viewed.

All Submissions:

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

Changes address original issue?
Tests included and/or updated with changes?
Has this been smoke tested?
Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
Have you associated a milestone with this PR? Note: leave blank if unsure.
Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

Changes appear to address issue?
Reviewer has tested changes by following the provided instructions?
Changes appear not to be breaking changes?
Appropriate automated tests included?
Code style and in-line documentation are appropriate?

…on annoatation tab

…urn annotatable types, cleaned up use of hasNumericTelemetry elsewhere in the code

Merging 2 inspector related branches for one PR.

codecov · 2025-01-15T19:01:56Z

Codecov Report

Attention: Patch coverage is 89.39394% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.54%. Comparing base (5be103e) to head (087fbd3).

Files with missing lines	Patch %	Lines
src/ui/inspector/InspectorTabs.vue	75.00%	1 Missing and 1 partial ⚠️
...gins/LADTable/LADTableConfigurationViewProvider.js	0.00%	1 Missing ⚠️
src/plugins/LADTable/plugin.js	0.00%	1 Missing ⚠️
...c/plugins/inspectorViews/elements/ElementsPool.vue	0.00%	1 Missing ⚠️
...spectorViews/styles/StylesInspectorViewProvider.js	87.50%	1 Missing ⚠️
...imelist/inspector/TimeListInspectorViewProvider.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7987      +/-   ##
==========================================
- Coverage   57.70%   54.54%   -3.16%     
==========================================
  Files         678      678              
  Lines       27428    27439      +11     
  Branches     2691     2694       +3     
==========================================
- Hits        15826    14966     -860     
- Misses      11264    12137     +873     
+ Partials      338      336       -2

Flag	Coverage Δ
e2e-ci	`53.34% <86.27%> (-9.48%)`	⬇️
e2e-full	`23.88% <62.74%> (-18.13%)`	⬇️
unit	`49.23% <71.21%> (-0.29%)`	⬇️

Files with missing lines	Coverage Δ
src/api/annotation/AnnotationAPI.js	`86.66% <100.00%> (-4.89%)`	⬇️
src/api/telemetry/TelemetryAPI.js	`89.92% <100.00%> (-0.12%)`	⬇️
src/api/types/TypeRegistry.js	`73.33% <100.00%> (+1.90%)`	⬆️
...gins/LADTable/components/LadTableConfiguration.vue	`0.00% <ø> (ø)`
...rts/bar/inspector/BarGraphInspectorViewProvider.js	`100.00% <100.00%> (ø)`
...tter/inspector/ScatterPlotInspectorViewProvider.js	`66.66% <100.00%> (-33.34%)`	⬇️
src/plugins/conditionWidget/plugin.js	`100.00% <100.00%> (ø)`
...ns/displayLayout/AlphanumericFormatViewProvider.js	`65.21% <100.00%> (ø)`
src/plugins/displayLayout/DisplayLayoutType.js	`100.00% <ø> (ø)`
...ns/displayLayout/components/AlphanumericFormat.vue	`0.00% <ø> (ø)`
... and 27 more

... and 110 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be103e...087fbd3. Read the comment docs.

- Alphanumeric formatting tab set to default priority while editing, low priority during browse. - Good styling for Format tab contents in browse mode. - Properties tab set to low priority during editing, default during browse.

- Make Elements pool visible in browse mode, omit edit capabilities.

- Edit and browse mode priorities for Properties and Elements.

- Adjusted edit and browse mode priorities for Properties and Elements. - Priority set for Gantt view.

charlesh88 · 2025-01-16T01:33:58Z

charlesh88 · 2025-01-16T01:37:01Z

Have pushed work:

Alphanumeric formatting tab set to default priority while editing, low priority during browse.
Good styling for Format tab contents in browse mode.
Make Elements pool visible in browse mode, omit edit capabilities.
Priorities set for Properties and Elements tabs in browse and edit modes: high/low and low/high, respectively.

… tab shows for them, setting it for older versions

…, keep it selected

- Priorities set for Graph, Lad Table, Scatter Plot, Telem Tables and Time List views. - Changed several Inspector tab names to 'Config'; tests and other code changed to target `key` instead of `name`: - LAD Table - Time List - will need regression testing for change noted re. `key` above. - Created browse mode read-only Inspector views: - LAD Table, Lad Table set. - Telemetry Table. and `showTab` functions; `showTab` has just been set to true for now. to prevent it from displaying when no filters can be set. - Changed AnnotationsViewProvider.js canView to return false if editor.isEditing. - Plot plugin.js now adds configuration.objectStyles {} for overlay and stacked plots on initialize. - FiltersView now displays a message for telem sources that don't have filter criteria available. - Code cleanup in FiltersInspectorViewProvider.js to remove metadata checks that never evaluated. - Annotations tab now set to never display when a view is being edited.

charlesh88 · 2025-01-17T20:41:02Z

Pushed:

Priorities set for Graph, Lad Table, Scatter Plot, Telem Tables and Time List views.
Changed several Inspector tab names to 'Config'; e2e tests updated where needed:
- LAD Table.
- Time List.
Created browse mode read-only Inspector views:
- LAD Table, Lad Table set.
- Telemetry Table.
Changed AnnotationsViewProvider.js canView to return false if editor.isEditing.
Added objectStyles: {} to initialize functions for multiple objects:
- Condition Widget
- Gauge
- LAD Table
- Overlay and Stacked Plots
FiltersView now displays a message for telem sources that don't have filter criteria available.
Code cleanup in FiltersInspectorViewProvider.js to remove metadata checks that never evaluated.

- Added `objectStyles: {}` to initialize functions for multiple objects: - Condition Widget - Gauge - LAD Table

jvigliotta added 9 commits December 20, 2024 14:22

added getTypes to types api, modifying which tabs are shown, working …

e196958

…on annoatation tab

moving hasNumericTelemetry to an api method

128f482

updated types api to return all types, updated annotations api to ret…

1326693

…urn annotatable types, cleaned up use of hasNumericTelemetry elsewhere in the code

not sure if scatter plots are annotatable

cded8fc

added annotation tab conditions

bac8c80

clean up the new hasNumericTelemetry method in the telemetry api

3cba87d

moving to canView, since that is where the logic should be

cc99f19

anytime a selection is updated, select the first (top priority) tab

0912f5f

Merge branch 'mct-7442' into mct-7959

59f855a

Merging 2 inspector related branches for one PR.

jvigliotta requested a review from charlesh88 January 15, 2025 18:56

This was referenced Jan 15, 2025

[Inspector Tabs] Make them more opinionated on where they show #7974

Closed

[Inspector Tabs] Highest priority tab selected on selection change #7979

Closed

charlesh88 added 4 commits January 15, 2025 16:22

Changes for tabs visibility and priority

ffa6ea6

- Alphanumeric formatting tab set to default priority while editing, low priority during browse. - Good styling for Format tab contents in browse mode. - Properties tab set to low priority during editing, default during browse.

Changes for tabs visibility and priority

9f1cac5

- Make Elements pool visible in browse mode, omit edit capabilities.

Changes for tabs visibility and priority

f199ce5

- Edit and browse mode priorities for Properties and Elements.

Changes for tabs visibility and priority

b09b9e0

- Adjusted edit and browse mode priorities for Properties and Elements. - Priority set for Gantt view.

jvigliotta and others added 6 commits January 16, 2025 08:50

update selection views on edit state change

97292d4

adding edit listener to inspector tabs component as well

e7eb070

intitializing display layouts with objectStyles properties, so styles…

7cd1517

… tab shows for them, setting it for older versions

initialize and backfill object styles config prop for flex layouts

4202de9

if editing and styles tab is selected and it exists for the next item…

f4f010a

…, keep it selected

Changes for tabs visibility and priority

087fbd3

- Added `objectStyles: {}` to initialize functions for multiple objects: - Condition Widget - Gauge - LAD Table

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inspector Tabs Updates #7987

Inspector Tabs Updates #7987

jvigliotta commented Jan 15, 2025

codecov bot commented Jan 15, 2025 •

edited

Loading

charlesh88 commented Jan 16, 2025 •

edited

Loading

charlesh88 commented Jan 16, 2025

charlesh88 commented Jan 17, 2025 •

edited

Loading

Inspector Tabs Updates #7987

Are you sure you want to change the base?

Inspector Tabs Updates #7987

Conversation

jvigliotta commented Jan 15, 2025

Describe your changes:

All Submissions:

Author Checklist

Reviewer Checklist

codecov bot commented Jan 15, 2025 • edited Loading

Codecov Report

charlesh88 commented Jan 16, 2025 • edited Loading

Todos

charlesh88 commented Jan 16, 2025

charlesh88 commented Jan 17, 2025 • edited Loading

codecov bot commented Jan 15, 2025 •

edited

Loading

charlesh88 commented Jan 16, 2025 •

edited

Loading

charlesh88 commented Jan 17, 2025 •

edited

Loading