Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test failure #205

Merged

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jun 4, 2024

GitHub Issue: #204

Description

This fixes the integration test failures that were happening because concatenation was happening even though concatenate=true was not passed to the Harmony request.

@chris-durbin helped diagnose the issue, and it was determined that in Harmony, currently
concatenate_by_default: true
So that "...if the SAMBAH chain is selected, the concatenate is true unless explicitly false."

We're pretty sure this logic/behavior was hidden and we avoided seeing it before because we had the l2-subsetter service associated to the collections also. Thus, when a request didn't have concatenate, it was processed by the standalone l2-susbetter service, not SAMBAH. However, as of now, we don't have the l2-subsetter standalone service associated, so it's all on the SAMBAH configuration logic.

Overview of integration done

Passing the integration test again.

PR Acceptance Checklist

  • [n/a] Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://stitchee--205.org.readthedocs.build/en/205/

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.84%. Comparing base (ab0118c) to head (a7461f3).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #205       +/-   ##
============================================
+ Coverage    22.11%   49.84%   +27.72%     
============================================
  Files           11       11               
  Lines          642      642               
============================================
+ Hits           142      320      +178     
+ Misses         500      322      -178     
Flag Coverage Δ
integration 43.92% <ø> (?)
unittests 22.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth added the bug Something isn't working label Jun 4, 2024
@danielfromearth danielfromearth self-assigned this Jun 4, 2024
@danielfromearth danielfromearth linked an issue Jun 4, 2024 that may be closed by this pull request
@danielfromearth danielfromearth merged commit 6337d3b into develop Jun 4, 2024
5 checks passed
@danielfromearth danielfromearth deleted the feature/issue-204-fix-integration-test-failure branch June 4, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix integration test failure in CI pipeline
2 participants