Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #204
Description
This fixes the integration test failures that were happening because concatenation was happening even though
concatenate=true
was not passed to the Harmony request.@chris-durbin helped diagnose the issue, and it was determined that in Harmony, currently
concatenate_by_default: true
So that "...if the SAMBAH chain is selected, the concatenate is true unless explicitly false."
We're pretty sure this logic/behavior was hidden and we avoided seeing it before because we had the l2-subsetter service associated to the collections also. Thus, when a request didn't have concatenate, it was processed by the standalone l2-susbetter service, not SAMBAH. However, as of now, we don't have the l2-subsetter standalone service associated, so it's all on the SAMBAH configuration logic.
Overview of integration done
Passing the integration test again.
PR Acceptance Checklist
CHANGELOG.md
updated📚 Documentation preview 📚: https://stitchee--205.org.readthedocs.build/en/205/