Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

fix: upgrade jszip to 3.7.1 to address DOS vulnerability #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bahizi
Copy link

@bahizi bahizi commented Aug 28, 2021

This is to address a DOS Vulnerability that is introduced by jszip < 3.7.0. See details here: https://app.snyk.io/vuln/SNYK-JS-JSZIP-1251497.

It's a very simple dependency update in package.json. I ran the tests and validated the sample Excel doc and all looked good.

Screen Shot 2021-08-27 at 7 55 14 PM

@bahizi
Copy link
Author

bahizi commented Sep 7, 2021

@natergj have you had a chance to review this?

@origooo
Copy link

origooo commented Oct 14, 2021

Would be super duper if this was merged!

@Scofield62
Copy link

Scofield62 commented Dec 6, 2021

Please merge it. I also need to get rid of vulnerabilities and I like using this library.

@sezanzeb
Copy link

sezanzeb commented Jan 18, 2022

You can add this to your package.json file to avoid the vulnerability:

  "resolutions": {
    "jszip": "^3.7.1"
  },

@fcastilloec
Copy link

You can add this to your package.json file to avoid the vulnerability:

  "resolutions": {
    "jszip": "^3.7.1"
  },

This will only work if you're using yarn. For the npm people, you need to use overrides

@arthurblake-AngelOak
Copy link

Unfortunately It looks like this excellent project might be abandoned by the author...
I hope @natergj is alive and well and on to better things.
I think our best bet going forward is this fork: https://www.npmjs.com/package/@advisr/excel4node
It looks like this issue is fixed in that fork as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants