When scheduling make sure to clean up empty assignments in zookeeper. #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix https://github.com/nathanmarz/storm/issues/551 The part when re-balancing causes the scheduled topologies to be in a bad state inside of ZK. It does not fix the race between updating nimbus writing new scheduling info and a supervisor trying to read that information. It also does not do anything to try and clean up workers that were running previously, but are not longer running. This can result in nimbus complaining about the workers no longer being alive when checking heartbeat timeouts. If this is important I can go back and try to see if there is something I can do to clean that up as well.