Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Apple Wallet code #76

Open
3 of 6 tasks
aahna-ashina opened this issue Sep 13, 2022 · 0 comments
Open
3 of 6 tasks

Refactor Apple Wallet code #76

aahna-ashina opened this issue Sep 13, 2022 · 0 comments
Assignees
@aahna-ashina

Comments

@aahna-ashina
Copy link
Member

aahna-ashina commented Sep 13, 2022 •
edited
Loading

Improve code maintainability/readability:

Improve stability of APNs integration:

  • Improve asynchronous calls to APNs in Passes.ts, so that a JSON response is not returned until all notification requests have been confirmed by APNs.
This was referenced Sep 13, 2022
Merged
Merged
@aahna-ashina aahna-ashina mentioned this issue Oct 13, 2022
Merged
4 tasks
@aahna-ashina aahna-ashina self-assigned this Oct 13, 2022
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 13, 2022
@aahna-ashina
refactor(apple): converting to/from milliseconds (nation3#76)
df21a4d
@aahna-ashina aahna-ashina mentioned this issue Oct 13, 2022
Merged
9 tasks
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 16, 2022
@aahna-ashina
refactor(apple): add dateutils class (nation3#76)
293fc43
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 16, 2022
@aahna-ashina
refactor(apple): add dateutils class (nation3#76)
f7d00b5
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 17, 2022
@aahna-ashina
refactor(apple):reduce the number of branches of code in [passTypeIde…
ecf3d0c 
…ntifier].ts (nation3#76)
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 19, 2022
@aahna-ashina
refactor(apple): use await instead of asynchronous (nation3#76)
36f5e8d 
```
json
{
    "summary": "1 sent, 3 failed",
    "sent": [ ... ],
    "failed": [ ... ]
}
```
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 19, 2022
@aahna-ashina
refactor(apple): fix type error (nation3#76)
88aa387
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 19, 2022
@aahna-ashina
test(apple): lower coverage threshold (nation3#76)
eaa5568
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 20, 2022
@aahna-ashina
chore(apple): add template version 4 (nation3#76)
f327105
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 20, 2022
@aahna-ashina
Revert "chore(apple): add template version 4 (nation3#76)"
5547aa7 
This reverts commit f327105.
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 20, 2022
@aahna-ashina
chore(apple): add template version 4 (nation3#76)
09ab583 
test(apple): debug template version 4

debug: add square icon

debug: restore original logo and strip

Revert "debug: restore original logo and strip"

This reverts commit 47d4345.

Revert "debug: add square icon"

This reverts commit bff7d91.

Revert "test(apple): debug template version 4"

This reverts commit 5bff363.

Revert "chore(apple): add template version 4 (nation3#76)"

This reverts commit f327105.
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 24, 2022
@aahna-ashina
refactor(apple): separate apn provider code (nation3#76)
8f8b829
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 25, 2022
@aahna-ashina
refactor(apple): separate apn provider code (nation3#76)
bbfa591
aahna-ashina added a commit to aahna-ashina/mobile-passport that referenced this issue Oct 25, 2022
@aahna-ashina
test(apple): mock apn provider during unit tests (nation3#76)
138492a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aahna-ashina aahna-ashina

Labels
None yet
Projects
🛂 Nation3 Passport
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aahna-ashina