-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): Add Splitbee analytics for pass downloads #33
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisivan This PR is both adding Splitbee and doing a lot of refactoring at the same time, so it's not easy for code reviewers to read the Splitbee code diff. Can you either 1) create one PR per change (one PR for refactoring, and another for Splitbee), or 2) create one PR with one commit per change (one commit for refactoring, and another for Splitbee)? Thanks! 😃
(Here is a great pull request philosophy: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#pull-request-philosophy)
Yeah... that's what I was mentioning above, since we didn't have a Prettifier config, just doing a save on my editor refactored the whole thing 😄 Maybe it's best to first merge #34, and then this one after (and then the changes will only affect Splitbee) |
@aahna-ashina ready to review again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (though I have not tested the changes on localhost
yet).
Out of curiosity: Where will the collected analytics be made available? On the Splitbee website I'm assuming?
PS: On a different note, we should add Prettifier config files to all projects to avoid noise in PRs