Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout update example plugin #12

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Conversation

ross-weir
Copy link
Member

@ross-weir ross-weir commented Aug 13, 2023

  • Fix incompatibility with axios timeout config due to missing nodejs api shim, use signals instead
  • Make example plugin do something with blockchain client
  • Add file logging, added a sync version of rotating log handler, its the same as RotatingFileHandler provided by deno std log except uses *Sync methods. Closes Add file log handler #10 - it looks like this handler being async in deno might be a bug, we should hopefully be able to remove this handler at some point in the future: Log handler setup function is inconsistent denoland/std#3538 (comment)

@ross-weir ross-weir requested a review from arobsn August 13, 2023 10:33
src/log.ts Outdated Show resolved Hide resolved
@ross-weir ross-weir mentioned this pull request Aug 13, 2023
@ross-weir ross-weir marked this pull request as draft August 14, 2023 08:40
@ross-weir ross-weir marked this pull request as ready for review August 14, 2023 09:00
@arobsn arobsn merged commit b98fe19 into main Aug 15, 2023
5 checks passed
@arobsn arobsn deleted the fix-timeout-update-example-plugin branch August 15, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file log handler
2 participants