Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to nautobot base templates #201

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

scetron
Copy link
Contributor

@scetron scetron commented Aug 17, 2022

This adopts the newer Nautobot base templates and fixes other minor issues with templates.

Fixes #196 and #177

@itdependsnetworks
Copy link

@chadell
Copy link
Contributor

chadell commented Aug 22, 2022

are these new templates available in all the Nautobot versions we support in the plugin? I mean, I know we make Nautobot Core backwards compatible, but maybe the new templates were not available before, so the plugin won't work in older versions of Nautobot.
I know there was a conversation about this few days ago. For instance, in Golden Config, there is a table of the minimum supported Nautobot version for the plugin version. Maybe we should do something like this here, instead of trying to keep full backwards compatibility in the plugin (keeping both templates versions, for instance)

@itdependsnetworks
Copy link

What we came to the conclusion on GC was. Let's not restrict (below a Nautobot 2.0) but let's be aggressive in bumping versions to not support older versions of Nautobot. This allows us to not have to worry about backwards compatibility and by logical sense, anything that breaks with the legacy versions is a Nautobot Core concern. Documented the approach here: https://github.com/nautobot/nautobot-plugin-golden-config/blob/develop/docs/admin/admin_install.md#deprecation-policy

@scetron
Copy link
Contributor Author

scetron commented Aug 23, 2022

I agree about following the model of Golden Config, I think it would be quite difficult to keep up with the feature velocity of Nautobot in our plugins if we had to make sure there was extensive backward compatibility.

@chadell
Copy link
Contributor

chadell commented Aug 23, 2022

Yes, I also agree that creating a well documented deprecation policy could grant us an easier development moving forward.
So, why not start on this PR? Plugin >=0.6.0 only supports Nautobot 1.4.0

@jvanderaa
Copy link
Collaborator

@chadell should we get this implemented before the 1.0.0? And possibly look to add nautobot.utilities.filters.MultiValueDateTimeFilter to the search?

@chadell
Copy link
Contributor

chadell commented Apr 18, 2023

Isn't most of it covered by 0f4a3a2 ?

For support nautobot.utilities.filters.MultiValueDateTimeFilter, we can tackle it as an improvement for a future minor release.

itdependsnetworks pushed a commit to itdependsnetworks/nautobot-app-circuit-maintenance that referenced this pull request Apr 3, 2024
@jvanderaa
Copy link
Collaborator

Looks like we have a lot out of date now @scetron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Object Detail View
4 participants