-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to nautobot base templates #201
base: develop
Are you sure you want to change the base?
Conversation
I think you need to bump this as well https://github.com/nautobot/nautobot-plugin-circuit-maintenance/blob/develop/nautobot_circuit_maintenance/__init__.py#L86 |
are these new templates available in all the Nautobot versions we support in the plugin? I mean, I know we make Nautobot Core backwards compatible, but maybe the new templates were not available before, so the plugin won't work in older versions of Nautobot. |
What we came to the conclusion on GC was. Let's not restrict (below a Nautobot 2.0) but let's be aggressive in bumping versions to not support older versions of Nautobot. This allows us to not have to worry about backwards compatibility and by logical sense, anything that breaks with the legacy versions is a Nautobot Core concern. Documented the approach here: https://github.com/nautobot/nautobot-plugin-golden-config/blob/develop/docs/admin/admin_install.md#deprecation-policy |
I agree about following the model of Golden Config, I think it would be quite difficult to keep up with the feature velocity of Nautobot in our plugins if we had to make sure there was extensive backward compatibility. |
Yes, I also agree that creating a well documented deprecation policy could grant us an easier development moving forward. |
@chadell should we get this implemented before the 1.0.0? And possibly look to add |
Isn't most of it covered by 0f4a3a2 ? For support |
Release v2.2.1
Looks like we have a lot out of date now @scetron |
This adopts the newer Nautobot base templates and fixes other minor issues with templates.
Fixes #196 and #177