Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update class path for job URL #205

Merged
merged 4 commits into from
Jan 8, 2024
Merged

update class path for job URL #205

merged 4 commits into from
Jan 8, 2024

Conversation

whitej6
Copy link
Contributor

@whitej6 whitej6 commented Jan 8, 2024

Device detail view raises an exception if capirca config was generated for the device due to v1.x reference of job

Copy link
Contributor

@snaselj snaselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI check needs to be fixed IMHO, otherwise LGTM

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>
Copy link
Contributor

@snaselj snaselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitej6 whitej6 merged commit 28ed409 into develop Jan 8, 2024
16 checks passed
@glennmatthews
Copy link
Contributor

This closes #203 correct?

@jdrew82 jdrew82 deleted the u/whitej6-issue-203 branch July 17, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants