Limit filtering match-all filter to DynamicGroups of group_type dynam… #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-filter Dynamic Groups of type dynamic-set have an empty filter, and were not being applied previously
johanek
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
| @@ -70,7 +70,7 @@ def get_job_filter(data=None): | |||
|
|
|||
| raw_qs = Q() | |||
| # If scope is set to {} do not loop as all devices are in scope. | |||
| if not models.GoldenConfigSetting.objects.filter(dynamic_group__filter__iexact="{}").exists(): | |||
| if not models.GoldenConfigSetting.objects.filter(dynamic_group__filter__iexact="{}", dynamic_group__group_type="dynamic-filter").exists(): | |||
There was a problem hiding this comment.
Getting verification, but can you import and then use the ChoiceSet definition: DynamicGroupTypeChoices.TYPE_DYNAMIC_FILTER instead of "dynamic-filter"
There was a problem hiding this comment.
Done, I've only taken into account filter and set groups - does anything need to be done to also support static groups?
There was a problem hiding this comment.
Will rope in @lampwins to help out here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ic-filter
Dynamic Groups of type dynamic-set have an empty filter, and were not being applied previously
This resolves #706