Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie updated by NetworkToCode Cookie Drift Manager Tool #179

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

nautobot-bot
Copy link
Contributor

Template:

{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.3.2",
    "path": null
}

Cookie:

{
    "remote": "https://github.com/nautobot/nautobot-app-netbox-importer.git",
    "path": "/tmp/tmp46v4lqd_/nautobot-app-netbox-importer",
    "repository_path": "/tmp/tmp46v4lqd_/nautobot-app-netbox-importer",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@glennmatthews @jathanism @lampwins @chadell",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_netbox_importer",
        "verbose_name": "Nautobot NetBox Importer",
        "app_slug": "nautobot-netbox-importer",
        "project_slug": "nautobot-app-netbox-importer",
        "repo_url": "https://github.com/nautobot/nautobot-app-netbox-importer",
        "base_url": "netbox-importer",
        "min_nautobot_version": "2.0.6",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotNetboxImporter",
        "project_short_description": "Data importer from NetBox 3.x to Nautobot 2.x.",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/netbox-importer/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmp46v4lqd_",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.3.2"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "d497fdc1a5c4fcb260a0e81ad4847806632f41bf",
    "draft": true
}

CLI Arguments:

{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.3.2",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}

bakebot and others added 4 commits August 29, 2024 03:41
Template:

```
{
    "template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
    "dir": "nautobot-app",
    "ref": "refs/tags/nautobot-app-v2.3.2",
    "path": null
}
```

Cookie:

```
{
    "remote": "https://github.com/nautobot/nautobot-app-netbox-importer.git",
    "path": "/tmp/tmp46v4lqd_/nautobot-app-netbox-importer",
    "repository_path": "/tmp/tmp46v4lqd_/nautobot-app-netbox-importer",
    "dir": "",
    "branch_prefix": "drift-manager",
    "context": {
        "codeowner_github_usernames": "@glennmatthews @jathanism @lampwins @chadell",
        "full_name": "Network to Code, LLC",
        "email": "opensource@networktocode.com",
        "github_org": "nautobot",
        "app_name": "nautobot_netbox_importer",
        "verbose_name": "Nautobot NetBox Importer",
        "app_slug": "nautobot-netbox-importer",
        "project_slug": "nautobot-app-netbox-importer",
        "repo_url": "https://github.com/nautobot/nautobot-app-netbox-importer",
        "base_url": "netbox-importer",
        "min_nautobot_version": "2.0.6",
        "max_nautobot_version": "2.9999",
        "camel_name": "NautobotNetboxImporter",
        "project_short_description": "Data importer from NetBox 3.x to Nautobot 2.x.",
        "model_class_name": "None",
        "open_source_license": "Apache-2.0",
        "docs_base_url": "https://docs.nautobot.com",
        "docs_app_url": "https://docs.nautobot.com/projects/netbox-importer/en/latest",
        "_template": "https://github.com/nautobot/cookiecutter-nautobot-app.git",
        "_output_dir": "/tmp/tmp46v4lqd_",
        "_repo_dir": "/github/home/.cookiecutters/cookiecutter-nautobot-app/nautobot-app",
        "_checkout": "refs/tags/nautobot-app-v2.3.2"
    },
    "base_branch": "develop",
    "remote_name": "origin",
    "pull_request_strategy": "PullRequestStrategy.CREATE",
    "post_actions": [
        "PostAction.BLACK"
    ],
    "baked_commit_ref": "d497fdc1a5c4fcb260a0e81ad4847806632f41bf",
    "draft": true
}
```

CLI Arguments:

```
{
    "cookie_dir": "",
    "input": false,
    "json_filename": "",
    "output_dir": "",
    "push": true,
    "template": "",
    "template_dir": "",
    "template_ref": "refs/tags/nautobot-app-v2.3.2",
    "pull_request": null,
    "post_action": [],
    "disable_post_actions": false,
    "draft": null
}
```
Comment on lines 137 to 139
- python-version: "3.12"
db-backend: "mysql"
nautobot-version: "stable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mysql support was disabled in #110 but I don't see any justification documented. I think we should keep it disabled or at least change it to 2.2 instead of stable as long as Nautobot v2.3 support hasn't been officially added to this app.

@gsnider2195 gsnider2195 marked this pull request as ready for review September 6, 2024 21:41
tasks.py Outdated Show resolved Hide resolved
@smk4664
Copy link

smk4664 commented Sep 7, 2024

It looks like the CI is not standard, at least with the unites matrix.

@gsnider2195
Copy link
Contributor

It looks like the CI is not standard, at least with the unites matrix.

The nautobot versions we're testing against don't support 3.12: nautobot-version: ["2.0.6", "2.1", "2.2"]

@gsnider2195
Copy link
Contributor

It looks like the CI is not standard, at least with the unites matrix.

The nautobot versions we're testing against don't support 3.12: nautobot-version: ["2.0.6", "2.1", "2.2"]

This app will need to be updated to support Nautobot v2.3

Copy link

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments! We will create followup tickets for those items.

@smk4664 smk4664 merged commit f1ddec5 into develop Sep 17, 2024
16 checks passed
@smk4664 smk4664 deleted the drift-manager/pr branch September 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants