Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implicit dependencies between tasks #102

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

sohyun-ku
Copy link
Contributor

Integration Test was disabled when run scavenger-agent-java:build that triggered by PR builder.
To solove this problem, we can use 'mustRunAfter' to specify the order between 'jar' and 'integrationTest' tasks.

https://github.com/naver/scavenger/actions/runs/6860169774/job/18653556996#step:5:102

Execution optimizations have been disabled for task ':scavenger-agent-java:integrationTest' to ensure correctness due to the following reasons:

  • Gradle detected a problem with the following location: '/home/runner/work/scavenger/scavenger/scavenger-agent-java/build/libs/scavenger-agent-java-1.1.1-SNAPSHOT.jar'. Reason: Task ':scavenger-agent-java:integrationTest' uses this output of task ':scavenger-agent-java:jar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.6.1/userguide/validation_problems.html#implicit_dependency for more details about this problem.

@sohyun-ku sohyun-ku self-assigned this Nov 14, 2023
@sohyun-ku sohyun-ku requested review from junoyoon and a team as code owners November 14, 2023 08:22
Copy link

Scavenger Test Results

159 files  159 suites   1m 34s ⏱️
266 tests 254 ✔️ 12 💤 0
284 runs  272 ✔️ 12 💤 0

Results for commit 7c7c931.

Copy link
Contributor

@taeyeon-Kim taeyeon-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was an issue with enabling jar tasks in #91.
Thanks you 😄 , it would have remained a serious bug if you hadn't checked the result of the action.

@taeyeon-Kim
Copy link
Contributor

Since the integration test passed in this PR, can we assume that the Support JDK 21 #101 PR is okay?

@sohyun-ku
Copy link
Contributor Author

Of course, this PR is after e944d38 commit :)

@sohyun-ku sohyun-ku merged commit bb9049a into develop Nov 14, 2023
5 checks passed
@sohyun-ku sohyun-ku deleted the feature/fix-implicit-dependencies-issue branch November 14, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants