-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to navigate signatures when package names start with a single prefix #104
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.example.demo.service2 | ||
|
||
import com.example.demo.annotation.ScavengerEnabled | ||
import com.example.demo.service.MyInterface | ||
import com.example.demo.service.MyParentService | ||
import org.springframework.stereotype.Service | ||
|
||
@ScavengerEnabled | ||
@Service | ||
class TestService : MyParentService(), MyInterface { | ||
fun call(): String { | ||
return "test" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,7 +182,7 @@ export default { | |
signature = candidate.signature; | ||
} else { | ||
signature = this.snapshotData.children | ||
.find(child => querySignature.startsWith(child.signature)).signature; | ||
.find(child => this.isStartsWithSignature(querySignature, child.signature)).signature; | ||
} | ||
await this.updateSnapshotData(signature); | ||
} | ||
|
@@ -328,6 +328,17 @@ export default { | |
resizeHorizontal(size) { | ||
localStorage.setItem("scavenger.snapshot.horizontal-size", size); | ||
}, | ||
isStartsWithSignature(querySignature, signature) { | ||
if (!querySignature.startsWith(signature)) { | ||
return false; | ||
} | ||
|
||
if (querySignature === signature) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This condition is true when searching for a class. |
||
return true; | ||
} | ||
|
||
return querySignature.substring(signature.length).startsWith("."); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this line means? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The package must be followed by a class, so check for a |
||
}, | ||
}, | ||
}; | ||
</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integrationTest was slowing down the build, so it was excluded.