This repository has been archived by the owner on Sep 12, 2018. It is now read-only.
Next브랜치에서 warn이 뜨는부분을 수정했습니다. #850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_type' type checking
|
어떤 warning인가요? |
|
:39와 :53에서 search_type을 match하는 부분에서 type check를 하게 되는데 여기서 warning이 떠서 수정했습니다. |
|
저한테는 warning이 재현이 안되서 어떤 warning인지 모르겠네요. warning 메시지를 알려주실 수 있으신지요? |
|
https://gist.github.com/seyriz/e74492cf2298a6715a42 |
|
AUTO에 대한 처리가 빠져서 나는 warning이군요. case SearchType.AUTO를 추가하거나 아니면 case SearchType.NA를 case _로 바꾸는 게 나을 것 같은데 어떻게 생각하세요? @keesun |
|
@npcode SearchType이 AUTO일땐 반드시 다른 타입으로 바뀌는 코드를 거친다음에 뷰로 가기 때문에 사실상 AUTO가 뷰까지 가지는 않겠지만 컴파일 경고 메시지를 줄이기 위해서라면 @seyriz 그렇게 바꿔서 보내주실 수 있으실까요? 감사합니다. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial_shearch에서 타입체크로 워닝이 떠서 눈에 안좋아 타입체크를 안하게 suppress 했습니다.