Fjern mellomledd for ferdigstilling av sak og oppgave #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Nov 7, 2024
| FerdigstillForespoerselSakMelding( | ||
| eventName = eventName, | ||
| transaksjonId = Key.UUID.les(UuidSerializer, json), | ||
| forespoerselId = Key.FORESPOERSEL_ID.lesOrNull(UuidSerializer, json) ?: Key.FORESPOERSEL_ID.les(UuidSerializer, data), |
There was a problem hiding this comment.
Lesing fra både json og data er midlertidig. Skal bytte fullstending over til data.
bjerga
commented
Nov 7, 2024
Comment on lines
+79
to
+84
| Key.DATA to | ||
| mapOf( | ||
| Key.FORESPOERSEL_ID to forespoerselId.toJson(), | ||
| Key.SPINN_INNTEKTSMELDING_ID to spinnInntektsmeldingId?.toJson(), | ||
| ).mapValuesNotNull { it } | ||
| .toJson(), |
There was a problem hiding this comment.
Smyger med denne for å gjøre forenklinger i bro-spinn senere.
b162214
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi har i dag en river hvis eneste jobb er å lese
INNTEKTSMELDING_MOTTATTog sende utFORESPOERSEL_BESVART. Jeg fjerner denne og leser hellerINNTEKTSMELDING_MOTTATTi neste ledd i kjeden.