Feature/nav 145 extract python client package #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor imports and rename to snake_case. - Fix mypy issues.
- Docker environment with running service. - Integration test cases.
…t need access to class attributes
- Use alias notation to parse correct fields.
- PublicTransitClientExceptions covers APIErrors. - Debug log parameters. - Instead of building the query string manually, pass a dict to requests.
- Why is this soo annoying in python?!? - Just convert it to statically typed language so the compiler can help!!!
- Run black and isort.
|
Added Docstrings and changed typing to newer approach without imports from typing.
I suggest implementing the changes to the API for the improved query configs in a separate issue. |
clukas1
previously approved these changes
Aug 20, 2024
clukas1
previously approved these changes
Aug 20, 2024
… also be between locations not only stops.
clukas1
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public transit service client Python package which works with the service v0.4.0.
Since the
snake_casenotation is used, the public transit viewer would need some adjustments. Also the new query parameters from NAV-131 are not yet supported.