Skip to content

Commit

Permalink
Upgrade Newtonsoft.Json to fix build
Browse files Browse the repository at this point in the history
Somehow the update to JsonRpcSharp caused cascading updates and
build was failing with errors like:

```
CSC : error CS1705: Assembly 'JsonRpcSharp.HttpClient' with identity
'JsonRpcSharp.HttpClient, Version=1.0.0.0, Culture=neutral, PublicKeyToken=d51963060d6195e8'
uses 'Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
which has a higher version than referenced assembly 'Newtonsoft.Json' with identity
'Newtonsoft.Json, Version=10.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed'
[D:\a\Nethereum\Nethereum\src\Nethereum.Signer.AzureKeyVault.Console\Nethereum.Signer.AzureKeyVault.Console.csproj]
```
  • Loading branch information
knocte committed Mar 3, 2024
1 parent cf82816 commit dd042ba
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions buildConf/Frameworks.props
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
</PropertyGroup>

<ItemGroup Condition=" '$(MSBuildProjectName)' != 'Nethereum.HdWallet'">
<PackageReference Include="Newtonsoft.Json" Version="[10.0.3,12)" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
</ItemGroup>

<ItemGroup Condition=" '$(MSBuildProjectName)' == 'Nethereum.HdWallet'">
<PackageReference Include="Newtonsoft.Json" Version="11.0.2" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<ItemGroup>
<PackageReference Include="Nethereum.ABI" Version="2.5.1" />
<PackageReference Include="Newtonsoft.Json" Version="11.0.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="[10.0.3,12)" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="JsonRpcSharp" Version="0.99.0--date20240303-0338.git-d673848" />
<PackageReference Include="Microsoft.Azure.KeyVault" Version="3.0.0" />
<PackageReference Include="Microsoft.IdentityModel.Clients.ActiveDirectory" Version="3.19.8" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="[10.0.3,12)" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Ledger.Net" Version="2.0.0" />
<PackageReference Include="Common.Logging" Version="3.4.1" />
<PackageReference Include="JsonRpcSharp" Version="0.99.0--date20240303-0338.git-d673848" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<ItemGroup>
<PackageReference Include="Trezor.Net" Version="2.4.0" />
<PackageReference Include="Newtonsoft.Json" Version="[10.0.3,12)" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="JsonRpcSharp" Version="0.99.0--date20240303-0338.git-d673848" />
</ItemGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="JsonRpcSharp" Version="0.99.0--date20240303-0338.git-d673848" />
<PackageReference Include="Newtonsoft.Json" Version="[10.0.3,12)" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="xunit" Version="2.3.1" />
</ItemGroup>
</Project>

0 comments on commit dd042ba

Please sign in to comment.