Merge PR #178 from webwarrior-ws/fix-pr177

FileConventions: account for .env prefix when checking versions
in yaml files.

This should have been done in PR177.

src/FileConventions.Test/DummyFiles/DummyWorkflowsWithEnvPrefixed/DummyCIWithPulumiVersionInEnvPrefixedV2.0.0.yml

@@ -0,0 +1,17 @@
+name: CI
+
+on: [push, pull_request]
+
+env:
+  PULUMI_VERSION: 2.0.0
+
+jobs:
+  jobA:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Pulumi CLI
+        with:
+          pulumi-version: ${{ env.PULUMI_VERSION }}
+      - name: Print "Hello World!"
+        run: echo "Hello World!"

src/FileConventions.Test/DummyFiles/DummyWorkflowsWithEnvPrefixed/DummyCIWithPulumiVersionInEnvPrefixedV2.0.1.yml

@@ -0,0 +1,17 @@
+name: CI
+
+on: [push, pull_request]
+
+env:
+  PULUMI_VERSION: 2.0.1
+
+jobs:
+  jobA:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Pulumi CLI
+        with:
+          pulumi-version: ${{ env.PULUMI_VERSION }}
+      - name: Print "Hello World!"
+        run: echo "Hello World!"

src/FileConventions.Test/FileConventions.Test.fs

@@ -429,6 +429,18 @@ let DetectInconsistentVersionsInGitHubCI2() =
 
     Assert.That(DetectInconsistentVersionsInGitHubCI fileInfo, Is.EqualTo true)
 
+[<Test>]
+let DetectInconsistentVersionsInGitHubCI3() =
+    let fileInfo =
+        DirectoryInfo(
+            Path.Combine(
+                dummyFilesDirectory.FullName,
+                "DummyWorkflowsWithEnvPrefixed"
+            )
+        )
+
+    Assert.That(DetectInconsistentVersionsInGitHubCI fileInfo, Is.EqualTo true)
+
 [<Test>]
 let DetectInconsistentVersionsInNugetRefsInFSharpScripts1() =
     let fileInfos =

src/FileConventions/Library.fs

@@ -337,9 +337,15 @@ let private DetectInconsistentVersionsInYamlFiles
                                     yamlDict.Children.["env"]
                                     :?> YamlMappingNode
 
-                                let envVarName =
+                                let referenceString =
                                     variableRegexMatch.Groups.[1].Value
 
+                                let envVarName =
+                                    if referenceString.StartsWith "env." then
+                                        referenceString.[4..]
+                                    else
+                                        referenceString
+
                                 match envDict.Children.TryGetValue envVarName
                                     with
                                 | true, envVarValue ->