scripts: fix unpinnedNugetPackage... script #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any other scripts doing this, how can they be working? |
|
Other scripts do use current directory, some also check script's parent dir. |
Which ones? |
|
Actually, this is the approach that needs to be used: abfde9a |
|
I don't understand logic of |
|
Because $SOMEPATH/externalRepo is always less nested than $SOMEPATH/externalRepo/conventions/scripts |
Use working dir instead of script's parent directory in unpinnedNugetPackageReferenceVersionsInProjects.fsx to search for projects as it is intended behavior.
webwarrior-ws
force-pushed
the
fix-unpinned-nuget-package-dir
branch
from
6f8e0ed to
ec4cb79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use working dir instead of script's parent directory in unpinnedNugetPackageReferenceVersionsInProjects.fsx to search for projects as it is intended behavior.