Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the missing tests for aclFile #13

Merged
merged 4 commits into from
Apr 18, 2024
Merged

adds the missing tests for aclFile #13

merged 4 commits into from
Apr 18, 2024

Conversation

ncode
Copy link
Owner

@ncode ncode commented Apr 18, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.43%. Comparing base (78ebd10) to head (93a664c).

Files Patch % Lines
pkg/aclmanager/aclmanager.go 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   81.15%   87.43%   +6.28%     
==========================================
  Files           1        1              
  Lines         191      191              
==========================================
+ Hits          155      167      +12     
+ Misses         31       19      -12     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncode ncode changed the title draft: tests adds the missing tests for aclFile Apr 18, 2024
@ncode ncode merged commit bce6e2d into main Apr 18, 2024
3 checks passed
@ncode ncode deleted the juliano/tests branch April 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants