Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and cleanup #15

Merged
merged 15 commits into from
Oct 19, 2024
Merged

Refactoring and cleanup #15

merged 15 commits into from
Oct 19, 2024

Conversation

ncode
Copy link
Owner

@ncode ncode commented Oct 12, 2024

This pull request includes significant updates to the README.md file, enhancements to the command-line interface, and improvements to the ACL manager's functionality. The most important changes are grouped by theme below.

Documentation Updates:

  • README.md: Updated project description, added a table of contents, expanded feature list, and detailed sections on getting started, development setup, usage, and contributing. [1] [2] [3]

Command-Line Interface Enhancements:

  • cmd/root.go: Added a syncInterval flag to specify the interval between sync operations and improved error handling messages. [1] [2] [3] [4] [5]
  • cmd/run.go: Introduced signal handling for graceful shutdown and added logging for the ACL manager loop. [1] [2]
  • cmd/runOnce.go: Improved error messages and ensured proper closing of the ACL manager. [1] [2]

Codebase Improvements:

Miscellaneous:

These changes collectively enhance the usability, maintainability, and functionality of the Bedel project.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (b9dd2b1) to head (13bb4cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/aclmanager/aclmanager.go 93.75% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   94.58%   95.11%   +0.53%     
==========================================
  Files           1        1              
  Lines         240      307      +67     
==========================================
+ Hits          227      292      +65     
- Misses         10       11       +1     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncode ncode merged commit 7c5cd3a into main Oct 19, 2024
6 of 7 checks passed
@ncode ncode deleted the juliano/updates branch October 19, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant