-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring and cleanup #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 94.58% 95.11% +0.53%
==========================================
Files 1 1
Lines 240 307 +67
==========================================
+ Hits 227 292 +65
- Misses 10 11 +1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. |
ncode
force-pushed
the
juliano/updates
branch
from
October 16, 2024 16:30
705087b
to
0701902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
README.md
file, enhancements to the command-line interface, and improvements to the ACL manager's functionality. The most important changes are grouped by theme below.Documentation Updates:
README.md
: Updated project description, added a table of contents, expanded feature list, and detailed sections on getting started, development setup, usage, and contributing. [1] [2] [3]Command-Line Interface Enhancements:
cmd/root.go
: Added asyncInterval
flag to specify the interval between sync operations and improved error handling messages. [1] [2] [3] [4] [5]cmd/run.go
: Introduced signal handling for graceful shutdown and added logging for the ACL manager loop. [1] [2]cmd/runOnce.go
: Improved error messages and ensured proper closing of the ACL manager. [1] [2]Codebase Improvements:
pkg/aclmanager/aclmanager.go
: Refactored to use theROLE
command for node discovery, added mutex for thread safety, and improved ACL synchronization logic. [1] [2] [3] [4] [5] [6] [7] [8]Miscellaneous:
configs/development/vault/setup.sh
: Updated the Vault setup script to wait for the Vault server to start on the correct hostname.These changes collectively enhance the usability, maintainability, and functionality of the Bedel project.