Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring #9

Merged
merged 14 commits into from
Dec 5, 2023
Merged

refactoring #9

merged 14 commits into from
Dec 5, 2023

Conversation

ncode
Copy link
Owner

@ncode ncode commented Dec 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (b06108a) 86.22% compared to head (c5f5fab) 92.02%.

Files Patch % Lines
pkg/aclmanager/aclmanager.go 83.92% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   86.22%   92.02%   +5.79%     
==========================================
  Files           1        1              
  Lines         167      163       -4     
==========================================
+ Hits          144      150       +6     
+ Misses         16        9       -7     
+ Partials        7        4       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncode ncode merged commit 4bc1cc1 into main Dec 5, 2023
5 checks passed
@ncode ncode deleted the juliano/refactoring branch December 5, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants