Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Names Should be Double Quoted #3

Open
danchirillo opened this issue Apr 26, 2020 · 0 comments
Open

Variable Names Should be Double Quoted #3

danchirillo opened this issue Apr 26, 2020 · 0 comments

Comments

@danchirillo
Copy link

You could get away with not enclosing variables whose values can't (or don't) contain spaces (like CPU), but several other variables (like VSPHERE_NODE_DATASTORE, VSPHERE_NETWORK, FOLDER, etc.) can easily have them.

Example update:

binaries/govc vm.create 
    -c=${CPU} \
    -m=${MEM} \
    -disk=${DISK}GB \
    -ds="${VSPHERE_NODE_DATASTORE}" \
    -net="${VSPHERE_NETWORK}" \
    -pool="${VSPHERE_POOL}" \
    -folder="${FOLDER}" \
    -on=false \
    -iso-datastore="${VSPHERE_IMAGE_DATASTORE}" \
    -iso="${VSPHERE_IMAGE_DATASTORE_PATH}/${OPENSHIFT_CLUSTERNAME}-${TYPE}-${COUNT}.iso" \
    "${OPENSHIFT_CLUSTERNAME}-${TYPE}-${COUNT}"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant