Use FetchContent instead of submodules #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephbirkner
changed the title
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
4 times, most recently
from
a61431f
to
be84b5c
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
from
be84b5c
to
c0e1006
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
from
654e7b3
to
e1c02ae
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
3 times, most recently
from
5fa5ad4
to
8337dd5
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
from
8337dd5
to
3176247
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
from
eb78033
to
08cdbde
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
from
5453a70
to
53d77ef
Compare
fklebert
force-pushed
the
less-submodules-introduce-conan
branch
from
4983d57
to
275f239
Compare
|
Before we merge this one, we should not forget to update the FetchContent part of the python-cmake-wheel dependency, which currently points to a fix branch. |
josephbirkner
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of submodules completely, by using either Conan2 or FetchContent repo copies.
Closes #100
Closes #101