fix: pin async-process crate #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frol Ready to be reviewed |
ghost
mentioned this pull request
frol
requested changes
Sep 30, 2023
crate/Cargo.toml
Outdated
| @@ -10,7 +10,7 @@ Utility library for launching NEAR sandbox environments. | |||
|
|
|||
| [dependencies] | |||
| anyhow = "1" | |||
| async-process = "1" | |||
| async-process = "=1.7.0" | |||
There was a problem hiding this comment.
Please, add a comment here referencing the issue on GitHub, so it is easy to review in the future if this version pinning would be still necessary.
Also, let's use <=1.7.0 to allow a wider range of versions if some other dependency would decide to pin it to <=1.6.0 or =1.6.0 version.
Also, consider reporting an issue to the async-process bug tracker.
ghost
requested a review
from
frol
approved these changes
Sep 30, 2023
|
Yes working on this now! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's was a test issue with linux that started after the time
async-process v1.8.0was released. This PR pins the package to the previous version. The issue concerned is left as a todo for later investigation/work.async-processIssue: smol-rs/async-process#55