feat: patch account and access keys added #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+194
to
+198
| account_id: &AccountId, | ||
| amount: Option<Balance>, | ||
| locked: Option<Balance>, | ||
| code_hash: Option<CryptoHash>, | ||
| storage_usage: Option<StorageUsage>, |
There was a problem hiding this comment.
Not sure, how to make a friendly API for this. Thinking of using builder here.
yeah definitely, would be great if we can get a builder going for this. You can take a look at patch.rs to see how to get one going. Probably also best to put it there as well
| @@ -158,6 +162,70 @@ impl Sandbox { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub(crate) async fn patch_account( | |||
There was a problem hiding this comment.
Can you add tests for this and patch_access_key. Let me know if they aren't as straightforward to implement, but they should be simple if you follow the ones in tests/patch_state.rs.
|
Closing in favor of #124. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to implement #19. Not sure, how to make a friendly API for this. Thinking of using builder here.