Testnet: error handling and add .testnet to dev_generate #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Jul 5, 2024
workspaces/src/network/variants.rs
Outdated
Comment on lines
80
to
84
| if self.info().name.eq("testnet") { | ||
| let id: AccountId = AccountId::from_str(format!("{}.testnet", id.as_str()).as_str()) | ||
| .expect("could not convert string account id into AccountId"); | ||
| return (id, sk); | ||
| } |
There was a problem hiding this comment.
This is not a maintainable way of addressing it. I cannot approve this PR with a workaround. Consider putting this code somewhere in the testnet dev_create_account/url_create_account implementation.
|
|
||
| let worker: Worker<Testnet> = near_workspaces::testnet().await?; | ||
| let (id, sk) = worker.dev_generate().await; | ||
| worker.create_tla(id, sk).await?.into_result()?; |
There was a problem hiding this comment.
This should not pass. TLA stands for top-level account (account name without ., e.g. near, testnet). create_tla on testnet cannot succeed.
added 2 commits
July 26, 2024 14:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling to url_create_account #353
Response from url_create_account method return next error: A top-level account ID AccountId("dev-20240701184705-27025377514474") can't be created by AccountId("testnet"), short top-level account IDs can only be created by AccountId("registrar")