Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed try_join to await futures #337

Merged
merged 6 commits into from
Aug 12, 2024
Merged

fix: removed try_join to await futures #337

merged 6 commits into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. feat: removed all try_join usage

    @frolvanya
    frolvanya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    36a5c53 View commit details
    Browse the repository at this point in the history

  2. chore: made clippy happy

    @frolvanya
    frolvanya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    650d59b View commit details
    Browse the repository at this point in the history

  3. refactor: removed macro usage

    @frolvanya
    frolvanya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    45e3144 View commit details
    Browse the repository at this point in the history

  4. fix: all variants have the same prefix (ReadRpc)

    @frolvanya
    frolvanya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    035d3d4 View commit details
    Browse the repository at this point in the history

  5. refactor: used block info from call_result 

    This triggered cargo clippy warning messages, so I decided to use `call_result.block...` instead of `block.block...`
    @frolvanya
    frolvanya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8965580 View commit details
    Browse the repository at this point in the history

  6. fix: addressed requested changes after review

    @frolvanya
    frolvanya committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    eee0597 View commit details
    Browse the repository at this point in the history