Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rpc_server): Add block_height_checker and Fix Chunk Fetch Bug #359

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Oct 7, 2024

1. Add block_height_checker

  • Implemented a block_height_checker to ensure that non-existing blocks are not fetched. This improvement prevents unnecessary fetch attempts for blocks that do not exist, optimizing resource usage and reducing potential errors.

2. Fix Bug with Fetch Chunk

  • Resolved a bug related to chunk fetching where the system was encountering issues with incomplete or incorrect chunk retrievals. This fix ensures that the chunk data is fetched correctly and reliably.

@kobayurii kobayurii self-assigned this Oct 7, 2024
@kobayurii kobayurii marked this pull request as ready for review October 7, 2024 10:36
@kobayurii kobayurii changed the title (rpc_server): Add block_height_cheker to avoid trying fetch not existing blocks (rpc_server): Add block_height_checker and Fix Chunk Fetch Bug Oct 7, 2024
@kobayurii
Copy link
Member Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths-bot
Copy link

race-of-sloths-bot commented Oct 7, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: waiting for scoring

We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of that huge nested if-else code block, but I can accept it

@kobayurii kobayurii merged commit cdc1f51 into database-new Oct 7, 2024
3 checks passed
@race-of-sloths-bot
Copy link

🥁 Score it!

@khorolets, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 1 🦥

@kobayurii kobayurii deleted the blocks/improvement branch October 9, 2024 08:39
@race-of-sloths
Copy link

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Great job! Usain Bolt jealous of your results!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 1

Your contribution is much appreciated with a final score of 1!
You have received 11 (10 base + 5% lifetime bonus) Sloth points for this contribution

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants