Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP-428 Wallet Selector Interface #917

Open
1 task
Tracked by #918
trechriron opened this issue Sep 13, 2023 · 0 comments
Open
1 task
Tracked by #918

NEP-428 Wallet Selector Interface #917

trechriron opened this issue Sep 13, 2023 · 0 comments
Assignees
Labels
Emerging Tech Emerging Tech flying formation at Pagoda

Comments

@trechriron
Copy link
Collaborator

trechriron commented Sep 13, 2023

Description

Please implement this interface to support NEP-428

NEPs: Add support for signing in to more than one contract at once to Injected Wallet Standard

From Osman Abdelnasir:

We need the signInMulti method and any other methods on the NEP to be added to the wallet selector interface so that wallets can implement it along with the current methods on the wallet selector interface. Probably should be added to BaseWalletBehaviour Link

contracts
signinMultiOptions

Ammar Humackic
July 4, 2023 at 4:37 AM

@amir Saran created PR #847 to address the comments made by Daryl (link).

Daryl Collins
June 26, 2023 at 5:42 AM

Added a review to the PR – we need to make sure that our behaviour is consistent when dapp developers use both signIn() and signInMulti() in combinations with the same contract IDs or different ones without adding duplicate state for a given contract ID.

Related Issues

  1. 0 of 1
    Emerging Tech
    kujtimprenkuSQA
@trechriron trechriron added Emerging Tech Emerging Tech flying formation at Pagoda Near BOS Epic Milestone or collection of like issues labels Sep 13, 2023
@trechriron trechriron removed the Epic Milestone or collection of like issues label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Emerging Tech Emerging Tech flying formation at Pagoda
Projects
None yet
Development

No branches or pull requests

2 participants