Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: argocd custom helm chart values exposed as a release artifact #208

Merged
merged 5 commits into from
Nov 10, 2023

Conversation

zaremba-tomasz
Copy link
Contributor

@zaremba-tomasz zaremba-tomasz commented Sep 28, 2023

What does this PR do?

In order to avoid the need to download the whole initium-platform repository just to install ArgoCD with custom values, additional artifact is being published to be used within helm upgrade --install command like below one:

helm upgrade --install argocd argo-cd \
  --repo https://argoproj.github.io/argo-helm \
  --values ./argocd-helm-values.yaml \
  --version 5.16.14 \
  --namespace argocd \
  --create-namespace

According to this doc yq should be available on GH runner.

Successfully tested on local, all works as expected (ArgoCD exluded from tilt up, installed with the above helm command).

When this one is merged and released we need to update the quick-start guides for all the clouds.

Related issues

Closes nearform/initium#15

Checklist before merging

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked the contributing document.
  • I have checked the existing Pull Requests to see whether someone else has raised a similar idea or question.
  • I have added tests that prove my fix is effective or that my feature works.

@zaremba-tomasz zaremba-tomasz marked this pull request as ready for review September 28, 2023 13:32
@ghost ghost self-requested a review September 28, 2023 13:46
@mablanco mablanco merged commit 1eeb8d6 into main Nov 10, 2023
10 checks passed
@mablanco mablanco deleted the feat/argocd-values-exposed branch November 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Come up with a better way to install ArgoCD on the platform
3 participants