feat: expose grafana and generate admin password #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- expose grafana on grafana.externalDomain - fail if externalDomain is not defined - generate the grafana admin password - add a tilt resource to read and output the generated password
most of the paths can be generated appending the addon name to the `/addons/` prefix
LucaLanziani
force-pushed
the
feature/expose-services
branch
from
c48f622
to
c044a69
Compare
|
To test this PR, destroy the cluster with: make tilt-downRecreate the whole stack makeGet the grafana passwor from tilt Get the cluster ingress address with kubectl get service -n istio-ingress istio-ingressgateway -o go-template='{{(index .status.loadBalancer.ingress 0).ip}}'Add the following entry to your hosts file <ingress-address> grafana.example.comNavigate to grafana.example.com and try to login as the admin user and the password you got from tilt |
|
I've destroyed and recreated cluster multiple times, and it doesn't always work, recorded here: FailGrafanaPassword.mp4After finding this behavior, I've deleted the pod and awaited for the new one to be in running state. Now when I've tried again, it worked. Main theory is that this problem happens when pod is created before the secret. |
|
No test changes required? |
mablanco
approved these changes
Nov 13, 2023
pablos4nt0s
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Please include a summary of the change, and please also include relevant motivation and context. List any dependencies that are required for this change.
Related issues
Please include a link to the issues related to this Pull Request.
Checklist before merging