Update japps custom page template to provide hub_title and favicon ba…

…sed on app configs, to match those used in the base page template.
nebari-dev · Sep 13, 2024 · 0877d09 · 0877d09
1 parent 9f0b15c
commit 0877d09
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/jhub_apps/service/japps_routes.py b/jhub_apps/service/japps_routes.py
@@ -27,6 +27,8 @@ async def handle_apps(request: Request):
         {
             "request": request,
             "version_hash": now.strftime("%Y%m%d%H%M%S"),
+            "hub_title": config.get("hub_title", "JupyterHub"),
+            "favicon": theme.get("favicon", "/service/japps/static/favicon.ico"),
             **theme,
         },
     )
diff --git a/jhub_apps/templates/japps_custom.html b/jhub_apps/templates/japps_custom.html
@@ -2,8 +2,9 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <title>JupyterHub Apps</title>
+    <title>{{ hub_title}}</title>
     <link rel="stylesheet" href="/hub/static/css/style.min.css" />
+    <link rel="icon" href="{{ favicon }}" type="image/x-icon" />
   </head>
   <body>
     <div id="root"></div>