Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Unit Test #432

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix Flaky Unit Test #432

merged 1 commit into from
Aug 2, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Aug 2, 2024

Reference Issues or PRs

N/A

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

  • Fixed test by updating to check for filter count before clicking button

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:10am
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 2:10am

Copy link
Contributor

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests everything passing. Look great!
Approved.

@jbouder jbouder merged commit 8a0e0fd into main Aug 2, 2024
25 checks passed
@jbouder jbouder deleted the fix-flaky-test branch August 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants