Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon missing on Create App pages #479

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Favicon missing on Create App pages #479

merged 1 commit into from
Sep 16, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Sep 13, 2024

Reference Issues or PRs

Fixes #477

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Screenshots

Screenshot 2024-09-13 at 3 34 27 PM

Any other comments?

  • Updated japps custom page template to provide hub_title and favicon based on app configs, to match those used in the base page template.

@jbouder
Update japps custom page template to provide hub_title and favicon ba…
0877d09 
…sed on app configs, to match those used in the base page template.
@jbouder jbouder added the type: bug 🐛 Something isn't working label Sep 13, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jhub-apps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 7:39pm
jhub-apps-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 7:39pm

@jbouder jbouder added the needs: review 👀 This PR is complete and ready for reviewing label Sep 16, 2024
kildre
kildre approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbouder jbouder merged commit 7a50a21 into nebari-dev:main Sep 16, 2024
25 checks passed
@jbouder jbouder deleted the favicon-fix branch September 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kildre kildre kildre approved these changes

@aktech aktech Awaiting requested review from aktech

@kcpevey kcpevey Awaiting requested review from kcpevey

Assignees
No one assigned
Labels
needs: review 👀 This PR is complete and ready for reviewing type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favicon missing on Create App pages
2 participants
@jbouder @kildre