From 0877d0913d59ae6dd026d87c4b2aec0fbe5e2dc6 Mon Sep 17 00:00:00 2001 From: Johnny Bouder Date: Fri, 13 Sep 2024 15:35:36 -0400 Subject: [PATCH] Update japps custom page template to provide hub_title and favicon based on app configs, to match those used in the base page template. --- jhub_apps/service/japps_routes.py | 2 ++ jhub_apps/templates/japps_custom.html | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/jhub_apps/service/japps_routes.py b/jhub_apps/service/japps_routes.py index 3c2a0371..a5b22753 100644 --- a/jhub_apps/service/japps_routes.py +++ b/jhub_apps/service/japps_routes.py @@ -27,6 +27,8 @@ async def handle_apps(request: Request): { "request": request, "version_hash": now.strftime("%Y%m%d%H%M%S"), + "hub_title": config.get("hub_title", "JupyterHub"), + "favicon": theme.get("favicon", "/service/japps/static/favicon.ico"), **theme, }, ) diff --git a/jhub_apps/templates/japps_custom.html b/jhub_apps/templates/japps_custom.html index cb59f101..40899e5d 100644 --- a/jhub_apps/templates/japps_custom.html +++ b/jhub_apps/templates/japps_custom.html @@ -2,8 +2,9 @@ - JupyterHub Apps + {{ hub_title}} +