Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kernel dialog sections sizing #69

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Fixes #40

When the number of environments >> number of running kernels

Here it is 44 (number of environments) >> 3 (number of running kernels)

Before After
image image

When number of environments << number of running kernels

Here 3 << 32

Before After
image image

When both hold comparable number of items

Here 16 == 16

Before After
image image

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

@krassowski krassowski added the bug label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-launchpad/kernel-dialog-sections-sizing

@krassowski krassowski merged commit 3af3c6b into main Sep 6, 2024
6 checks passed
@krassowski krassowski deleted the kernel-dialog-sections-sizing branch September 6, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UI for Create New modal
1 participant