Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7 + Ruby 3 update #96

Merged
merged 31 commits into from
Jul 24, 2024
Merged

Rails 7 + Ruby 3 update #96

merged 31 commits into from
Jul 24, 2024

Conversation

Valiec
Copy link
Collaborator

@Valiec Valiec commented Jul 9, 2024

Draft PR to update primer-monitor to Rails 7 and Ruby 3. It's mostly done, but still needs further testing of course.

@Valiec Valiec requested a review from bwlang July 15, 2024 20:09
@Valiec Valiec marked this pull request as ready for review July 15, 2024 20:10
Copy link
Member

@bwlang bwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of minor questions...

config/application.rb Show resolved Hide resolved
app/models/organism.rb Show resolved Hide resolved
@Valiec
Copy link
Collaborator Author

Valiec commented Jul 15, 2024

Found one bug, Select2 messes up on the edit user page:
Screenshot 2024-07-15 at 4 21 52 PM

@Valiec
Copy link
Collaborator Author

Valiec commented Jul 15, 2024

Also, I have 3 indices to add (I forgot those).

@Valiec Valiec merged commit cd2948b into master Jul 24, 2024
1 of 2 checks passed
@bwlang bwlang deleted the rails-7 branch November 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants