Make GrGit exceptions return false result (issue #2) #3
Conversation
|
Apologies, but not sure what that error is or what I might have done to cause it. Happy to amend if I could get a hint. |
|
@scrain not you - we've been seeing this intermittently on some of our repositories on Travis. Thanks for the PR, will review it properly as soon as we're able. |
|
In fact, I bet it's the clone depth - if the last commit to be tagged is outside of Travis' default clone depth, this will fail. Seeing the same failure on master, I'll fix that so you can rebase and get this PR built. |
|
That should do it. Pull master from us and rebase onto your PR branch. |
…eturn-false' into make-grgit-errors-return-false
|
Just a bump on this for awareness. Think everything should be good now. Thanks! |
|
Any update on getting this fixed? This PR is ancient and yet the bug still exists and caused us to miss the fact that some pushes were failing. |
This should resolve issue #2