Support scrubbing absolute temporary paths in test_html.py on Windows #1771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gold files, like
tests/gold/html/other/index.html
record an absolute path that includes the temporary directory used while testing, like:There's explicit support for the directory format above in the regex:
However, when creating the gold files on Windows, the absolute path takes a rather different format, for example:
This PR adds a new regex to match and scrub directories in the format above: