Skip to content

Commit

Permalink
tsm_getvolumecontent: Don't skip damaged files(2)
Browse files Browse the repository at this point in the history
The fix in commit f866fb0 to not skip
damaged files turned out to be incomplete.

If a volume was flagged access=unavailable or similar then files on it
would not be included and we would see very frequent retries.

This commit changes the volume list retrieval to only ignore volumes that
are empty or are pending (ie. empty/reclaimed but on deletion hold due to
storage pool reusedelay!=0).

Should also reduce the impact of #21
  • Loading branch information
ZNikke committed Oct 8, 2019
1 parent 014f34c commit 09f46cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tsm_getvolumecontent.pl
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ sub debug

# List volumes in the storage pools
foreach my $stgpool (sort @stgpools) {
my @t=dsm_cmd("q vol stg=$stgpool access=readwrite,readonly status=online,filling,full") or die "Failed listing vols for $stgpool";
my @t=dsm_cmd("q vol stg=$stgpool status=online,offline,filling,full") or die "Failed listing vols for $stgpool";
foreach my $line (@t) {
my($volname, undef, undef, undef, undef, undef) = split (/\t/, $line);
push @volumes, $volname;
Expand Down

0 comments on commit 09f46cd

Please sign in to comment.