Fix .net 9 suppressions

nemesissoft · Jan 8, 2025 · b6854dd · b6854dd
1 parent 190d91d
commit b6854dd
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 6 deletions.
diff --git a/Nemesis.TextParsers/CompatibilitySuppressions.xml b/Nemesis.TextParsers/CompatibilitySuppressions.xml
@@ -1,10 +1,28 @@
 <?xml version="1.0" encoding="utf-8"?>
-<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
-<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<Suppressions xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
   <Suppression>
     <DiagnosticId>CP0006</DiagnosticId>
     <Target>P:Nemesis.TextParsers.Settings.ISettings`1.Default</Target>
-    <Left>lib/net6.0/Nemesis.TextParsers.dll</Left>
+    <Left>lib/netstandard2.0/Nemesis.TextParsers.dll</Left>
+    <Right>lib/net8.0/Nemesis.TextParsers.dll</Right>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0021</DiagnosticId>
+    <Target>M:Nemesis.TextParsers.Parsers.NumberTransformerCache.GetNumberHandler``1``0:T:System.Numerics.IBinaryInteger{``0}</Target>
+    <Left>lib/netstandard2.0/Nemesis.TextParsers.dll</Left>
+    <Right>lib/net8.0/Nemesis.TextParsers.dll</Right>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0021</DiagnosticId>
+    <Target>T:Nemesis.TextParsers.Parsers.EnumTransformer`3``1:T:System.Numerics.IBinaryInteger{`1}</Target>
+    <Left>lib/netstandard2.0/Nemesis.TextParsers.dll</Left>
+    <Right>lib/net8.0/Nemesis.TextParsers.dll</Right>
+  </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0021</DiagnosticId>
+    <Target>T:Nemesis.TextParsers.Parsers.NumberTransformer`1``0:T:System.Numerics.IBinaryInteger{`0}</Target>
+    <Left>lib/netstandard2.0/Nemesis.TextParsers.dll</Left>
     <Right>lib/net8.0/Nemesis.TextParsers.dll</Right>
   </Suppression>
 </Suppressions>
diff --git a/Nemesis.TextParsers/Nemesis.TextParsers.csproj b/Nemesis.TextParsers/Nemesis.TextParsers.csproj
@@ -13,13 +13,18 @@
 
 	<!--Legacy on-->
 	<PropertyGroup>
-		<AllowUnsafeBlocks Condition=" '$(TargetFramework)' == 'netstandard2.0' ">true</AllowUnsafeBlocks>
+		<ApiCompatGenerateSuppressionFile>true</ApiCompatGenerateSuppressionFile>
+		<ApiCompatPermitUnnecessarySuppressions>true</ApiCompatPermitUnnecessarySuppressions>
+	</PropertyGroup>
+
+	<PropertyGroup>
+		<AllowUnsafeBlocks Condition=" '$(TargetFramework)' == 'netstandard2.0' ">true</AllowUnsafeBlocks>		
 	</PropertyGroup>
 
 	<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
 		<PackageReference Include="System.Memory" />
 	</ItemGroup>
-
+	
 	<!--Legacy off-->	
 
 </Project>
diff --git a/Nemesis.TextParsers/SpanSplit.cs b/Nemesis.TextParsers/SpanSplit.cs
@@ -2,13 +2,16 @@
 
 namespace Nemesis.TextParsers;
 
+#if NET9_0_OR_GREATER
+//[Obsolete("Use approprtiate System.MemoryExtensions.Split method", false)]
+#endif
 public static class SpanSplitExtensions
 {
     #region Enumerators
     public readonly ref struct Enumerable1<T> where T : IEquatable<T>
     {
         public Enumerable1(ReadOnlySpan<T> sequence, T separator, bool emptySequenceYieldsEmpty)
-        {
+        {            
             _sequence = sequence;
             _separator = separator;
             _emptySequenceYieldsEmpty = emptySequenceYieldsEmpty;