Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] CLI & Service Application #3103

Closed

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 21, 2024

Description

This PR is to focus on the a new CLI & service. Also to fix the problems and bottlenecks at hand with the current CLI. The goal is not to change anything in core at least in this PR. But in the future will be changing Plugins and adding a WebServer in the CLI that Plugins can tie into.

How Basic Design Works

The way this is going to work is with two applications. One that is a Service that can run in linux with systemd and in windows as a WindowsService. The other application is a command-line based app that talks to the ServiceApp by using NamedPipes/IPC systems.

Features

  • All things in current CLI
  • Command-line based (With Prompt)
  • IPC NamedPipes (For Service)
  • Multi-Node support
  • Full Node
  • Lite Node
  • Development Node
  • Consensus Node
  • Debug Server
  • Smart Contract Tracer
  • Run as a OS Service
  • Offline mode
  • New archive/backup file format
  • Detailed mass logging - anything & everything
  • Plugin automation installation (download from nuget)
  • Expanded configuration file - (config.json removed)
  • New wallet management system

More to come...

Your Feedback is Requested!

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@roman-khimov
Copy link
Contributor

Does it solve #3014?

@cschuchardt88
Copy link
Member Author

@roman-khimov Sure does

@cschuchardt88
Copy link
Member Author

@Jim8y @shargon

Should I just setup this PR up for review? It's Incomplete but this will become really big PR. I got the basic layout scaffold setup.

@Jim8y
Copy link
Contributor

Jim8y commented Jun 24, 2024

@Jim8y @shargon

Should I just setup this PR up for review? It's Incomplete but this will become really big PR. I got the basic layout scaffold setup.

create a branch and break this pr into smaller ones. That is currently the only way to make it work.

@cschuchardt88
Copy link
Member Author

@Jim8y @shargon
Should I just setup this PR up for review? It's Incomplete but this will become really big PR. I got the basic layout scaffold setup.

create a branch and break this pr into smaller ones. That is currently the only way to make it work.

I'm ok with other branch. But how am I to break down PR for something that is built already. I'm not understanding that part.

@Jim8y
Copy link
Contributor

Jim8y commented Jun 24, 2024

an issue that list your plan, add few classes that has no dependency issues on every pr. i am not trying to make it hard for you, just current coredev protocol wont work well on long pr.

@cschuchardt88
Copy link
Member Author

See PR #3372 PAIRT-1 to PART-7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants