Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Neo Core] Nullable #3125

Closed
wants to merge 38 commits into from
Closed

[Neo Core] Nullable #3125

wants to merge 38 commits into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Feb 8, 2024 •
edited
Loading

Description

This is a pr that trys to replace #3118. Will update the description later.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y marked this pull request as draft February 8, 2024 02:08
Jim8y and others added 24 commits February 8, 2024 10:16
@Jim8y
Revert "use nullable smartcontract"
28a1cca 
This reverts commit f687908.
@Jim8y
Revert "use nullable crypto"
d91a92c 
This reverts commit 8145c4d.
@Jim8y
Revert "Revert "use nullable crypto""
3db49dc 
This reverts commit d91a92c.
@Jim8y
use nullable ledger
119cc80
@Jim8y
update UInt 160 and 256
0143dd1
@Jim8y
use nullable wallet
23511bc
@Jim8y
revoke wallet
53f8196
@Jim8y
nullable IO
fecb839
@Jim8y
use part of contract nullable
6240fca
@Jim8y
Revert "use part of contract nullable"
343cb9b 
This reverts commit 6240fca.
@Jim8y
nullable manifest
9960d06
@Jim8y
Merge branch 'master' into nullable
921010c
@Jim8y
nullable contract
b38b617
@Jim8y
smart contract nullable
a12e8b1
@Jim8y
add more nullable to contracts
e4c6c18
@Jim8y
more contract nullable
ba7b50d
@Jim8y
Merge branch 'nullable' of github.com:Jim8y/neo into nullable
103ad43 
* 'nullable' of github.com:Jim8y/neo:
  [Neo Fix] fix the store crash issue (neo-project#3124)
  [Neo VM: FIX] the GetString() methods of bytestring requires strictUTF8 (neo-project#3110)
@Jim8y
more nullable for smart contract
af3fc79
@Jim8y
fix UT
cfaa143
@Jim8y
more nullable to smart contract
666983a
@Jim8y
more nullable to smart contract
52c01de
@Jim8y
update format
6e86102
@Jim8y
more nullable, 570 nullable warnings to go
0337a17
@Jim8y
add more nullable
8d7558b
@Jim8y Jim8y mentioned this pull request Feb 9, 2024
Closed
12 tasks
@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 9, 2024

I will stop from here for now. The workload is so heavy and so hard to debug. Will need @superboyiii to check the compatibility before I keep going, otherwise, it will be hard to locate the issue.

@Jim8y Jim8y marked this pull request as ready for review February 9, 2024 10:52
@Jim8y Jim8y closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jim8y