Fix bug in MemorySnapshot #3133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jim8y Any idea about how to fix |
shargon
added
blocker
Jim8y
approved these changes
Feb 11, 2024
cschuchardt88
requested changes
Feb 11, 2024
Comment on lines
+68
to
74
| if (writeBatch.TryGetValue(key, out var value)) | ||
| { | ||
| return value; | ||
| } | ||
|
|
||
| immutableData.TryGetValue(key, out value); | ||
| return value?[..]; |
There was a problem hiding this comment.
This should return null? If not then change writeBatch to do the same.
There was a problem hiding this comment.
Yes, it returns null when it's not found
There was a problem hiding this comment.
Do you see the difference? In the returns?
There was a problem hiding this comment.
Why are we creating a new pointer?
|
It seems that |
They use a bloom filter. Our memory store does not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Snapshot data is not taken into account during memory store reading
Type of change