Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neo CLI NEW] Part 1 of https://github.com/neo-project/neo/pull/3103 #3369

Closed
wants to merge 1 commit into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jun 29, 2024

Description

This is part one of pr #3103, this pr mainly focus on create the whole structure of new cli.

This pr does not introduce any real functonal logic, all of them are sort of tools and utils.

Fixes # #3103

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Neo.Hosting.App.Tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y requested a review from cschuchardt88 June 29, 2024 15:05
@Jim8y Jim8y changed the base branch from new-cli to master June 29, 2024 15:07
@Jim8y Jim8y changed the base branch from master to new-cli June 29, 2024 15:07
@Jim8y Jim8y added the blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Jun 29, 2024
Copy link
Member

@cschuchardt88 cschuchardt88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1 and Part 2 are the same code

@shargon
Copy link
Member

shargon commented Jul 1, 2024

Part 1 and Part 2 are the same code

So only part 2 is needed?

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jul 1, 2024

@shargon
ignore these. start with #3372 and go up

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jul 2, 2024

@Jim8y thx for the help. But we don't need your PRs anymore for new-cli.

@cschuchardt88
Copy link
Member

No longer need this PR see #3372

@Jim8y Jim8y deleted the part-1 branch July 19, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Issues that are blocking other issues. Check issues details to see what it is blocking. waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants