Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hardofork HF_Echidna #3454

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

Add hardofork HF_Echidna #3454

wants to merge 35 commits into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Aug 7, 2024

@Jim8y Jim8y added the blocked This issue can't be worked at the moment label Aug 7, 2024
@Jim8y Jim8y marked this pull request as draft August 7, 2024 16:44
AnnaShaleva
AnnaShaleva reviewed Aug 7, 2024
View reviewed changes
src/Neo.CLI/config.fs.mainnet.json Outdated
@@ -40,7 +40,8 @@
"HF_Aspidochelone": 3000000,
"HF_Basilisk": 4500000,
"HF_Cockatrice": 5800000,
"HF_Domovoi": 5800000
"HF_Domovoi": 5800000,
"HF_Echidna": 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna enum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to plan when we're going to have the next release. May be we can postpone configuration changes until some real proximity to the release and in this PR add only HF_Echidna enum?

Its placeholder, can be updated before merge to the master.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make configs stored in the master branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna (we need it and will use it), but update configs later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make configs stored in the master branch unusable for real synchronization for some time, nothing good about that. Better omit it, declare HF_Echidna (we need it and will use it), but update configs later.

this will not be merged to the master branch until we decides to release new version.

@shargon
Add entries to Designation event (#3397)
e63f10b 
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
@Jim8y Jim8y added this to the v3.8.0 milestone Aug 8, 2024
Jim8y and others added 2 commits August 8, 2024 20:09
@Jim8y @shargon @cschuchardt88
[Neo Json Fix] Json null tests (#3450)
28043cb 
* null operation

* fix array

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
@Jim8y
[Neo Core StdLib] Add Base64url (#3453)
9d16c53 
* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.
This was referenced Aug 12, 2024
Merged
Draft
chenzhitong and others added 20 commits August 13, 2024 14:11
@chenzhitong
Update README.md (#3459)
a93adb7
@chenzhitong @Jim8y
Update RpcServer.Blockchain.cs (#3458)
0d46c20 
Co-authored-by: Jimmy <jinghui@wayne.edu>
@cschuchardt88 @shargon
Set Password to SecureString for Wallet (#3468)
5fb2262 
* Set `Password` to `SecureString` for Wallet information

* Added `UnitTest` for `SecureStringExtensions`

* Update tests/Neo.Extensions.Tests/UT_SecureStringExtensions.cs

Co-authored-by: Shargon <shargon@gmail.com>

* Update src/Neo.Extensions/SecureStringExtensions.cs

---------

Co-authored-by: Shargon <shargon@gmail.com>
@Jim8y @shargon @NGDAdmin
[Neo Plugin RPCServer] Rpc parameters. Part I (#3457)
71da68d 
* rpc parameter parse

* update blockchain related apis.

* Update src/Plugins/RpcServer/RpcMethodWithParamsAttribute.cs

* Delete src/Plugins/RpcServer/JsonPropertyNameAttribute.cs

* udpate contract model

* Update src/Plugins/RpcServer/Model/BlockHashOrIndex.cs

* Apply suggestions from code review

Remove comments

* Update src/Plugins/RpcServer/RpcServer.cs

* fix warnings

* ensure it can load both true/false and 1/0

* optimize the pr and add unit tests

* add more tests and check the safe max value and safe min value

* remove format

* remove unused

* format

* Apply suggestions from code review

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@Hecate2 @shargon @NGDAdmin
test RpcServer.Utilities, .SmartContract and .Wallet (#3461)
436906c 
* test RpcServer.Utilities

* test invoke function and script

* TestTraverseIterator

* TestGetUnclaimedGas

* RpcServerSettings.Default with { SessionEnabled = true }

* test call with storage changes and events

* use wallet in invokefunction

* use invalid wallet

* invoke without signer

* all cases for TraverseIterator

* traversing same session twice; not expired session

* cover OnTimer

* test deserializing complex signers

* use Assert.ThrowsException

* TestSendFrom and TestSendMany

* apply code review with `nameof`

* test cancel transaction

* TestInvokeContractVerify

* improve error message

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@cschuchardt88 @shargon
@Jim8y @NGDAdmin
[Move] Part-4 Classes into Different Library - Neo.Extensions (#3408
ab46242 
)

* Part-1 `Neo.IO` - move

* Part-2

* Added `BigInteger` to `Neo.Extensions`

* Found more `BigInteger`

* Added `ByteArray` to `Neo.Extensions`

* Added `DateTime` Extensions to `Neo.Extensions`

* Added `HashSetExtensions`, `HashSetExtensions2`, `IpAddressExtensions`, `AssemblyExtensions`, `StringExtensdions`
Deleted `Helper.cs` file

* Added Tests

* Added `tests` from `Part-2`

* Added `tests` for `PART-4`

* Add `using Neo.Extensions` for unit tests

* Change `HashSetExtensions2` to `HashSetExtensions`

* Update tests/Neo.Extensions.Tests/UT_BigIntegerExtensions.cs

* Update and rename StringExtensdions.cs to StringExtensdios.cs

* Rename StringExtensdios.cs to StringExtensions.cs

* `dotnet format`

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@chenzhitong
Add UT Neo.IO (#3466)
23f1bce 
* UT_KeyedCollectionSlim

* Update UT_KeyedCollectionSlim.cs

* Update UT_MemoryReader.cs

* Update UT_MemoryReader.cs
@Hecate2
improve error message when wrong wallet is opened (#3469)
dc926f7 
* improve error message when wrong wallet is opened

* update tests
@chenzhitong
Update UT RpcServer (#3460)
9ce9c6f 
* Update UT_RpcServer.Blockchain.cs

* Update UT_RpcServer.Blockchain.cs

* update

* fixed bug

* format

* update

* Update NativeContractExtensions.cs

* update

* Remove conflicting files

* update

* format
@cschuchardt88 @shargon @Jim8y
[fixes] UInt160 Class (#3422)
5fe5462 
* Fixed `UInt160` and expanded class

* Cleaned up code for `TryParse`

* Fixed `TryParse`

* Fixed small bug with `TryParse`

* Change `UInt160.Zero` to `static readonly`

* benchmark UInt160

* Fix benchmark

* Fixed bugs and added features for `UInt160` class

* Revert and just keep bug fixes

* Made @shargon changes

* Set `InvariantCultureIgnoreCase` back for `0x` and `0X`

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Jimmy <jimmy@r3e.network>
@Hecate2 @shargon
test GetApplicationLog (#3470)
e018bc3 
* test GetApplicationLog

* filter execution type

* Test_Commands; refactor

* apply review suggestions

---------

Co-authored-by: Shargon <shargon@gmail.com>
@chenzhitong @NGDAdmin @Jim8y
Add UT Neo.Extensions (#3467)
c69791f 
* Add UT Neo.Extensions

* resolve conflicts

* Revert "resolve conflicts"

This reverts commit 6d0a61b.

* add edge case

* update mod test

---------

Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Jimmy <jimmy@r3e.network>
@chenzhitong
Add some UT (#3476)
da193e9 
* Update UT_Utility.cs

* TestGetContractState
@kov072299 @shargon
@Jim8y @NGDAdmin
Update ConstantTimeUtility.cs (#3472)
3d663f2 
- Fix typo

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@Hecate2 @Jim8y @shargon
Test OracleService (#3475)
2b118b4 
* trigger https oracle

* make it internal

* return Task.CompletedTask

---------

Co-authored-by: Jimmy <jimmy@r3e.network>
Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>
@Jim8y @cschuchardt88 @shargon
[Neo Plugin RPC] update rpc node methods signatures to use explicit p…
9788280 
…arameter types. (#3479)

* update rpc node methods signatures to use explicit parameter types.

* fix attribute place

---------

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Shargon <shargon@gmail.com>
@chenzhitong
Fixing errors in comments (#3483)
ff58726 
* Update OpCode.cs

* Update JumpTable.Compound.cs

* Update OpCode.cs
@Hecate2 @vncoelho
parse nef file scripts (#3482)
c6282cd 
* parse nef file scripts

* nef file path support

---------

Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
@Jim8y
[Neo VM Style] Throw exception for Integer that is larger than 32 byt…
9946450 
…es (#3486)

* fix push integer

* Update src/Neo.VM/ScriptBuilder.cs

* Update tests/Neo.VM.Tests/UT_ScriptBuilder.cs

* Update tests/Neo.VM.Tests/UT_ScriptBuilder.cs
@chenzhitong
Update RpcError.cs (#3498)
a52e321
nan01ab and others added 11 commits September 26, 2024 23:57
@nan01ab @shargon
fix: concurrency conflict in HeaderCache.Count (#3501)
d6ed5a5 
* fix: concurrency conflict in HeaderCache.Count

* Update tests/Neo.UnitTests/Ledger/UT_HeaderCache.cs

* Update tests/Neo.UnitTests/Ledger/UT_HeaderCache.cs

---------

Co-authored-by: Shargon <shargon@gmail.com>
@cschuchardt88 @Jim8y
@shargon @NGDAdmin
[Add] Transaction Builder (#3477)
73cea01 
* Added Builders with tests

* Added SignerBuilder and started WitnessRuleBuilder

* Added `WitnessConditionBuilder` with tests

* Added more logic

* Fixed `SignerBuilder` class

* Code touch ups

* Added more tests

* Update src/Neo/Builders/TransactionBuilder.cs

* Fixed `And` `Or` and `Not` conditions

* Fixed Memory leak

* Added error message for Witness scripts

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@cschuchardt88 @shargon @NGDAdmin
[Fix] Neo Plugins github nuget (#3493)
6a4ea1f 
* Fixed Delete packages for github

* Automatic

* added continue-on-error: true

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@cschuchardt88 @shargon @Jim8y
[Move] Part-5 Classes into Different Library - Neo.Extensions (#3409
9287c66 
)

* Part-1 `Neo.IO` - move

* Part-2

* Added `BigInteger` to `Neo.Extensions`

* Found more `BigInteger`

* Added `ByteArray` to `Neo.Extensions`

* Added `DateTime` Extensions to `Neo.Extensions`

* Added `HashSetExtensions`, `HashSetExtensions2`, `IpAddressExtensions`, `AssemblyExtensions`, `StringExtensdions`
Deleted `Helper.cs` file

* Added `ICollection`, `Memory`,  `String`, `Unsafe` extensions

* Adding `using`

* dotnet format

* Added Tests

* Added `tests` from `Part-2`

* Added `tests` for `PART-4`

* Added `tests` for `PART-5`

* Made changes and fixes

* Fixes

* Apply suggestions from code review

* Update tests/Neo.Extensions.Tests/UT_StringExtensions.cs

* @shagron review changes

* formating

* Moved `UnsafeData` tests to `UT_UnsafeData`

* Formating

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
@nan01ab
fix: always throw DivideByZeroException when BloomFilter is empty (
33d0913 
#3502)

* fix: always throw divided by zero when BloomFilter is empty

* fix: always throw divided by zero when BloomFilter is empty
@nan01ab @shargon @Jim8y
fix: concurrency conflict in MemPool.TryRemoveUnVerified (#3500)
6e74e33 
* fix: concurrency conflict in MemPool.TryRemoveUnVerified

* Remove method

* Update src/Neo/Ledger/MemoryPool.cs

* clean

* Apply suggestions from code review

* reformat

---------

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jimmy <jinghui@wayne.edu>
@Jim8y
update rvcount error message (#3504)
1688a7a
@Jim8y
add hardofork HF_Echidna
f746f8d
@shargon @Jim8y
Add entries to Designation event (#3397)
8d7f9e8 
* Add entries to Designation event

* Change to HF_Echidna

* Add UT

* Add count
@Jim8y
[Neo Core StdLib] Add Base64url (#3453)
3fc8077 
* add base64url

* active in

* update placehold hf height

* fix hf issue and move methods to proper place.

* fix test

* use identifymodel instead.
@Jim8y
Merge branch 'HF_Echidna' of github.com:neo-project/neo into HF_Echidna
620d938 
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@AnnaShaleva AnnaShaleva AnnaShaleva left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked This issue can't be worked at the moment
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Jim8y @roman-khimov @AnnaShaleva @shargon @chenzhitong @cschuchardt88 @Hecate2 @kov072299 @nan01ab